fix: log unexpected GRPC server errors at INFO#692
Merged
anthony-swirldslabs merged 1 commit intomainfrom Nov 20, 2025
Merged
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
JUnit Test Report 78 files ±0 78 suites ±0 3m 46s ⏱️ -5s Results for commit 8dd306a. ± Comparison against base commit 7060326. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both. |
jsync-swirlds
approved these changes
Nov 20, 2025
Member
jsync-swirlds
left a comment
jsync-swirlds
left a comment
There was a problem hiding this comment.
Thanks for the rapid fix on this.
Integration Test Report 410 files ±0 410 suites ±0 16m 23s ⏱️ - 1m 14s Results for commit 8dd306a. ± Comparison against base commit 7060326. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both. |
imalygin
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
PbjProtocolHandler.javalogs unexpected errors at ERROR level, but in most cases they are harmless for the server itself. ERROR logs trigger various alarms when analyzing logs. So we want to log these at INFO level instead.Also, I'm ensuring that the
error()is called even if sending trailers fails.Related issue(s):
Fixes #691
Notes for reviewer:
All tests should pass.
Checklist